Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR implements the code for Miller-Rabin primality test in C#, Java, Python referred in issue #79 #113

Merged
merged 4 commits into from
Oct 5, 2020
Merged

This PR implements the code for Miller-Rabin primality test in C#, Java, Python referred in issue #79 #113

merged 4 commits into from
Oct 5, 2020

Conversation

96Octavian
Copy link
Contributor

This PR implements the code for Miller-Rabin primality test in C#, Java, Python referred in issue #79

I have read the contributing guidelines in CONTRIBUTING.md and have ensured the following:

  • My code is placed in the required directory as outlined in CONTRIBUTING.md
  • My code file is named according to CONTRIBUTING.md
  • Variables, classes, functions etc. follow camel case as outlined in CONTRIBUTING.md
  • My code hasn't been implemented or claimed by someone else and I have checked the present issues and PRs for the same
  • My code is well commented
  • If my code is the first implementation of Miller-Rabin primality test, I have added the link to this directory in README.md
  • I have not copied my code from anywhere

deutranium
deutranium approved these changes Oct 5, 2020
View reviewed changes
Copy link
Owner

@deutranium deutranium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is a reeeaalllyyyy good PR. Great job!!

@deutranium deutranium merged commit 943cd72 into deutranium:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deutranium deutranium deutranium approved these changes

@RishKhanna RishKhanna Awaiting requested review from RishKhanna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@96Octavian @deutranium